Create py.typed for use with mypy #27942
Conversation
Create type stubs file to allow `mypy` and other type checkers to run on user's pipelines.
Codecov Report
@@ Coverage Diff @@
## master #27942 +/- ##
=======================================
Coverage 72.23% 72.24%
=======================================
Files 684 684
Lines 100946 100961 +15
=======================================
+ Hits 72921 72937 +16
+ Misses 26445 26444 -1
Partials 1580 1580
Flags with carried forward coverage won't be shown. Click here to find out more. see 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Thanks, @davidcavazos . We need to include Apache licences in all files to pass RAT check. |
Co-authored-by: Jack McCluskey <[email protected]>
CHANGES.md
Outdated
| @@ -84,6 +84,7 @@ | |||
| * Transform service controller container. | |||
| * Spark3 job server container. | |||
| * Added support for batched writes to AWS SQS for improved throughput (Java, AWS 2).([#21429](https://github.com/apache/beam/issues/21429)) | |||
| * Added support to run `mypy` on user pipelines ([#27906](https://github.com/apache/beam/issues/27906)) | |||
There was a problem hiding this comment.
this change didn't make the release cut unfortunately.
There was a problem hiding this comment.
It's currently under 2.50.0 Unreleased, I don't see a 2.51 so what should we do with this?
There was a problem hiding this comment.
If you pull in the changes from the master branch there is a 2.51 section - https://github.com/apache/beam/blob/master/CHANGES.md
|
Reminder, please take a look at this pr: @damccorm |
damccorm
added
Next Action: Author
and removed
Next Action: Reviewers
slow-review
labels
|
The only open issue is where to announce the change in CHANGES.md, but I don't know where we should place it. Can someone point me in the right direction? |
|
If you pull in the changes from master (sync your fork then |
|
Reminder, please take a look at this pr: @damccorm |
damccorm
added
Next Action: Author
and removed
Next Action: Reviewers
slow-review
labels
|
Updated CHANGES for 2.51 |
fixes #27906
Create type stub marker to allow
mypyand other type checkers to run on user pipelines.R: @aaltay @tvalentyn
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.